Merged
Conversation
This commit also brings in changes to add_field and add_vector_field to
avoid using the setattr method. Instead, we opt to extend the dictionary
for the fields (which map {field.name : field}). The add_vector_field
method optionally adds the VectorField object (if it's not already
present) and each of its components by calling add_field
Contributor
VeckoTheGecko
left a comment
VeckoTheGecko
left a comment
There was a problem hiding this comment.
@fluidnumerics-joe feel free to re-request a review once the changes we discussed are pushed :)
We're most interested in having users be explicit about passing vector components if they plan on using kernels that require each explicitly
The particleset init and execute functions need a fairly major overhaul to accomodate changes in the field/fieldset. I think this work would be better pushed to another PR
Contributor
Author
|
@VeckoTheGecko - I've opted to skip the tests involving |
Contributor
Author
|
@VeckoTheGecko - Ready to review again |
VeckoTheGecko
requested changes
Apr 30, 2025
Contributor
VeckoTheGecko
left a comment
VeckoTheGecko
left a comment
There was a problem hiding this comment.
Small change, but once that's fixed LGTM!
VeckoTheGecko
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainfor v3 changes,v4-devfor v4 changes)This PR cleans up init for list of fields and fix v4 test errors. It brings in changes to
add_fieldandadd_vector_fieldto avoid using thesetattrmethod. Instead, we opt to extend the dictionary for the fields (which map{field.name : field}). Theadd_vector_fieldmethod optionally adds theVectorFieldobject (if it's not already present) and each of its components by callingadd_field.tests/v4is now updated to use the new list of fields.@VeckoTheGecko - there are still a few
TODO: Nickitems listed in here to keep things safe and tidy.